Skip to content

Alias trapezoid function for Numpy v1/v2 - #57

Merged
PNOGillespie merged 1 commit into
no-structure-guardfrom
fix-numpy
Sep 30, 2026
Merged

PNOGillespie merged 1 commit into
no-structure-guardfrom
fix-numpy

Conversation

@edan-bainglass

Copy link
Copy Markdown
Collaborator

QE app requires Numpy v2, but we don't want to force the backend to v2. Adding a simple alias to handle this.

@PNOGillespie PNOGillespie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @edan-bainglass. I'll be sure to have a discussion about implementing tests (as mentioned in #56)

@PNOGillespie
PNOGillespie merged commit 510329f into main Sep 30, 2026
2 checks passed
@PNOGillespie
PNOGillespie deleted the fix-numpy branch September 30, 2026 09:28
@edan-bainglass

Copy link
Copy Markdown
Collaborator Author

Looks good @edan-bainglass. I'll be sure to have a discussion about implementing tests (as mentioned in #56)

Yikes! I didn't think you'd merge also 😅 So this one was stacked on #56 (which got merged as a result of this merge), and... #56 was rebased #55, so by merging #56 (via merging this one), we now already include #55. Fun 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants