Feature/aliyun oss adapter#180
Open
ringtail (ringtail) wants to merge 1 commit into
Open
Conversation
|
FYI I think #110 will make the route replace fixes in this PR unnecessary. |
Collaborator
|
Is there not S3 compatibility? GCS was used for the initial POC but we already support S3 API. |
Author
Author
Good point! OSS does support S3-compatible API (endpoint: s3.oss-{region}.aliyuncs.com), and our use case (GetObject/PutObject for snapshots) is fully covered. The current S3 adapter just needs an endpoint override to work with OSS directly. I'll update this PR to:
|
…tomization - Rename internal/ategcs to internal/objectstorage with clear file separation (storage.go, gcs.go, s3.go) - Add AWS_ENDPOINT_URL_S3 support to S3 adapter, enabling connection to any S3-compatible storage (Alibaba Cloud OSS, MinIO, R2, etc.) - Remove dedicated OSS adapter in favor of S3-compatible mode - Update atelet.yaml with S3+OSS configuration example - Retain ParseObjectURL support for oss:// URL scheme This allows Alibaba Cloud OSS users to use the existing S3 adapter by simply setting AWS_ENDPOINT_URL_S3 to the OSS S3-compatible endpoint (e.g. https://s3.oss-cn-hangzhou-internal.aliyuncs.com).
ec45241 to
c35ab30
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Add Alibaba Cloud OSS storage backend & fix gVisor network restore on ACK clusters
Problem
OSS Storage Backend
Agent Substrate currently only supports GCS as the snapshot storage backend, preventing deployment in Alibaba Cloud environments. OSS support is needed for multi-cloud compatibility.
gVisor Network Restore Failure
On ACK (Alibaba Container Service for Kubernetes) clusters, ResumeActor fails 100% of the time with:
Root cause: Terway CNI uses 169.254.1.1 (link-local) as the pod gateway. This address is unreachable from gVisor's interior network namespace since it exists on the host side of the veth pair.
Solution
OSS Adapter
oss://bucket/pathURL scheme in ParseObjectURLATE_STORAGE_BACKEND=oss,OSS_ENDPOINT,OSS_ACCESS_KEY_ID,OSS_ACCESS_KEY_SECRETLink-Local Route Graceful Fallback
restoreLink(), whennetlink.RouteReplace()fails, check if the gateway is a link-local address usingnet.IP.IsLinkLocalUnicast()Testing
Unit Tests
Benchmark Results
Environment: ACK cluster, OSS internal endpoint (oss-ap-northeast-1-internal.aliyuncs.com), single worker serial loop.
Acceptance Results