Fix make with LDFLAGS

[Tim Hockin (thockin)]

$(KO) != $(GO)

ko does not support any way to pass build flags directly. We have to
use GOFLAGS. Go does not fully shell-parse GOFLAGS, it just does simple
whitespace splitting and whole-value quoting.

E.g. this fails for good reason:
GOFLAGS="-ldflags=-X=foo=foo -X=bar=bar"
...becomes:
[ "go", "build", "-ldflags=-X=foo=foo", "-X=bar=bar" ]
...where -X is passed to go build

We can try:
GOFLAGS="-ldflags='-X=foo=foo -X=bar=bar'"
...but that becomes
[ "go", "build", "-ldflags='-X=foo=foo", "-X=bar=bar'" ]
...which is unfortunate.

Go does some quote handling, but:
GOFLAGS='-ldflags="-X=foo=foo -X=bar=bar"'
...still becomes:
[ "go", "build", "-ldflags="-X=foo=foo", "-X=bar=bar"" ]
...which is surprising.

We can try:
GOFLAGS="-ldflags=-X=foo=foo -ldflags=-X=bar=bar"
...but go just takes the last value of that flag rather than the accumulation.

What does work is:
GOFLAGS='"-ldflags=-X=foo=foo -X=bar=bar"'
...with the WHOLE flag quoted.

[Benjamin Elder (BenTheElder)]

How does this behave with the install scripts, which do not use the makefile at all AFAIK?

[Benjamin Elder (BenTheElder)]

Do we really need ldflags? Why not just use the Go-buil- in version stamping? Kubernetes uses ldflags because this functionality didn't exist.

[Tim Hockin (thockin)]

There's no way I can see to set a version string in Go's build info?

[Benjamin Elder (BenTheElder)]

Go automatically grabs the version from git

[Tim Hockin (thockin)]

vcs.revision is the commit, we want a symbolic name for releases

[Tim Hockin (thockin)]

Found a way to make GOFLAGS work.