feat(serverboot): set service.instance.id on the telemetry resource#155
Merged
Haven Xia (HavenXia) merged 1 commit intoJun 5, 2026
Conversation
Haven Xia (HavenXia)
approved these changes
Jun 5, 2026
Collaborator
Haven Xia (HavenXia)
left a comment
There was a problem hiding this comment.
Thanks for the instance id fix, without it multiple instances of one service collapse onto a single backend time series.
atenet-router also runs serverboot in #157 and now emits metrics; without this env block it'll fall back to a random UUID instance id on every restart. I'll add the matching block in #157
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #154
Give
serverboot's OTel resource a per-instance identity so multi-instance components (e.g. theateletDaemonSet) don't collide in the backend, and honorOTEL_RESOURCE_ATTRIBUTES. The shared tracer/meter resource now carriesservice.instance.id(UUID fallback) withWithFromEnvlast so env overrides defaults (ErrPartialResource/ErrSchemaURLConflictare non-fatal), and theate-api-serverDeployment /ateletDaemonSet inject pod identity via the Downward API (service.instance.id=$(POD_UID),k8s.namespace.name/pod.name/pod.uid).