Skip to content

feat(serverboot): set service.instance.id on the telemetry resource#155

Merged
Haven Xia (HavenXia) merged 1 commit into
agent-substrate:mainfrom
konippi:feat/serverboot-telemetry-resource
Jun 5, 2026
Merged

feat(serverboot): set service.instance.id on the telemetry resource#155
Haven Xia (HavenXia) merged 1 commit into
agent-substrate:mainfrom
konippi:feat/serverboot-telemetry-resource

Conversation

@konippi
Copy link
Copy Markdown
Contributor

Fixes #154

Give serverboot's OTel resource a per-instance identity so multi-instance components (e.g. the atelet DaemonSet) don't collide in the backend, and honor OTEL_RESOURCE_ATTRIBUTES. The shared tracer/meter resource now carries service.instance.id (UUID fallback) with WithFromEnv last so env overrides defaults (ErrPartialResource/ErrSchemaURLConflict are non-fatal), and the ate-api-server Deployment / atelet DaemonSet inject pod identity via the Downward API (service.instance.id=$(POD_UID), k8s.namespace.name/pod.name/pod.uid).

  • Tests pass
  • Appropriate changes to documentation are included in the PR

@HavenXia Haven Xia (HavenXia) self-assigned this Jun 5, 2026
@HavenXia Haven Xia (HavenXia) self-requested a review June 5, 2026 05:35
Copy link
Copy Markdown
Collaborator

@HavenXia Haven Xia (HavenXia) left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the instance id fix, without it multiple instances of one service collapse onto a single backend time series.

atenet-router also runs serverboot in #157 and now emits metrics; without this env block it'll fall back to a random UUID instance id on every restart. I'll add the matching block in #157

@HavenXia Haven Xia (HavenXia) merged commit dffe585 into agent-substrate:main Jun 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add per-instance identity to the telemetry resource

2 participants