Implement parsing of select CSS declarations#188
Draft
afishhh wants to merge 8 commits into
Draft
Conversation
Make final inline layout operate on differently-typed items. This allows us to re-use the shaped items for multiple layout attempts and means new information can be added to items before layout without needing to assert its presence later.
maybe split into two commits?
TODO: split out csssyn addition into separate commit?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incredibly WIP.
Stacked on top of #187 and a commit implementing images in the layout engine (yet to be PR-ed).
Switches layout test class definitions to parsing CSS declarations too.
Does not implement selectors (so still no WebVTT STYLE blocks for now).
TODO:
TODOs are within the new codecsssynas a separate crate, move outParse{Stream,Error}(can be deferred as future work)