Repository navigation
Conversation
🧪️ Preview Links 🔎️Mainnet: https://pr-1179-aescan.stg.service.aepps.com |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useWebSocket's reconnect handler (openWebSocket()) re-subscribes to atransaction hash using
source: "node", but the live watcher for the samesubscription (
watch(subscribedTransactionId, ...)) usessource: "mdw".Only
source: "mdw"supports subscribing to an arbitrary tx hash payload —source: "node"only handles theKeyBlocks/MicroBlockschannel names.So after any websocket reconnect (network blip, backend restart) while a user
is on a transaction detail page, the re-subscription silently goes nowhere —
that transaction's live confirmation update never fires again until a full
page reload.
Demo
No visual change — this only affects a background websocket subscribe
message sent after reconnect.
Checklist: