Update incorrect callback documentation#328
Open
cpjolicoeur wants to merge 1 commit into
Open
Conversation
`before_delete` is passed the conn and changeset according the the current codebase, it is not based the conn and record itself. This commit updates the documentation to more accurately reflect the current codebase and the fact that `before_delete` isn't unique in receive different argument than other `before_*` callbacks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before_deleteis passed the conn and changeset according the the current codebase, it is not based the conn and record itself.This commit updates the documentation to more accurately reflect the current codebase and the fact that
before_deleteisn't unique in receive different argument than otherbefore_*callbacks.IF the intent is/was to actually pass the record itself instead of a changeset to
before_delete, please advise and I'll gladly update the PR to make the applicable changes to the callbacks code to accurately reflect the current README documentation (instead of updating the docs to reflect the current code).