Skip to content

[#190][BUG] embedded_schema @primary_key false not supported#200

Open
marinho10 wants to merge 9 commits into
aesmail:masterfrom
coletiv:master
Open

[#190][BUG] embedded_schema @primary_key false not supported#200
marinho10 wants to merge 9 commits into
aesmail:masterfrom
coletiv:master

Conversation

@marinho10

Copy link
Copy Markdown

Closes #190 .

Fix error when in embedded_schema have @primary_key false

@marinho10

Copy link
Copy Markdown
Author

@rageofflames please see

build_html_input(changeset.data, form, {field, options}, type, opts)
end

defp build_html_input(schema, form, {field, options}, type, opts, readonly \\ false) do

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aesmail can you double check this chunk of code to see if it affects any logic?

@ghenry

ghenry commented Apr 12, 2023

Copy link
Copy Markdown
Collaborator

Hi,

Would you be so kind as to do this again to the master branch?

Thanks,
Gavin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] embedded_schema @primary_key false not supported

3 participants