Skip to content

add posibility to add image preview in show/edit page#161

Open
sulphur wants to merge 5 commits into
aesmail:masterfrom
sulphur:master
Open

add posibility to add image preview in show/edit page#161
sulphur wants to merge 5 commits into
aesmail:masterfrom
sulphur:master

Conversation

@sulphur

@sulphur sulphur commented Oct 20, 2020

Copy link
Copy Markdown

No description provided.

@aesmail

aesmail commented Oct 20, 2020

Copy link
Copy Markdown
Owner

Thank you @sulphur
This is definitely a good PR. I'd change some minor things though.

  1. Instead of checking for the type inside the form_field function, you might want to move that inside the build_html_input function where all the types are already being checked and the function returns the necessary html.
    Check this line.

  2. For the new type names, image_preview and custom_html are good, but we can make them shorter like image and html. Less typing, and meaning is preserved.

I think this PR is ready to be merged once this is done 👍🏼

@sulphur

sulphur commented Dec 3, 2020

Copy link
Copy Markdown
Author

Hi, Sure I can change it to html and image. However I just wanted to point out before that html and image aren't form inputs that is why I didn't put them inside buitd_html_input since this function creates form elements. Tell me what you think and I will update the PR accordingly.

@kelcecil kelcecil added the enhancement New feature or request label Sep 20, 2021
@artempankov

Copy link
Copy Markdown

is there any chance for merging this request? ))

@Faymir

Faymir commented Sep 5, 2022

Copy link
Copy Markdown

Hello, any news about this pull request ?

@aesmail

aesmail commented Sep 5, 2022

Copy link
Copy Markdown
Owner

I will try to merge this for the next release 👍🏻

@ghenry

ghenry commented Apr 12, 2023

Copy link
Copy Markdown
Collaborator

Hi @sulphur

Would you be so kind as to do this again to the master branch?

Thanks,
Gavin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants