You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you @sulphur
This is definitely a good PR. I'd change some minor things though.
Instead of checking for the type inside the form_field function, you might want to move that inside the build_html_input function where all the types are already being checked and the function returns the necessary html.
Check this line.
For the new type names, image_preview and custom_html are good, but we can make them shorter like image and html. Less typing, and meaning is preserved.
I think this PR is ready to be merged once this is done 👍🏼
Hi, Sure I can change it to html and image. However I just wanted to point out before that html and image aren't form inputs that is why I didn't put them inside buitd_html_input since this function creates form elements. Tell me what you think and I will update the PR accordingly.
Would you be so kind as to do this again to the master branch?
Thanks,
Gavin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.