feat: allow returning null prop#89
Open
flozdra wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
No linked issue.
❓ Type of change
📚 Description
Returning page props that have a
nullvalue will cause an error in theserializemethod (see here).However, this use case can be useful when there is no resource. For example:
A workaround would be to return
undefinedinstead ofnull, but in that case, the prop is not replaced in the view by Inertia since it is undefined.Another solution would be to compute the result outside the callback, but it removes the benefits of partial reloads:
This PR allows the
unpackPropValuefunction to directly return anullvalue, bypassing the serializer.I'm not sure if this is the right place to handle the escape case.
📝 Checklist