Skip to content

refactor: create shared ew canvas header.#992

Open
kozmaadrian wants to merge 2 commits into
mainfrom
ew-shared-canvas-header
Open

refactor: create shared ew canvas header.#992
kozmaadrian wants to merge 2 commits into
mainfrom
ew-shared-canvas-header

Conversation

@kozmaadrian

@kozmaadrian kozmaadrian commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Extracts the ew canvas header into a shared component in blocks/shared/, so the base header can back other "canvas" too, e.g. SC Editor.

  • New ew-canvas-header-base: renders the bar with a built-in toggle-before button and three slots.
  • ew-canvas-header (canvas): same as before, but now composes the base canvas. The undo/redo, the view toggle, and the after toggle go in via slots
  • Reusable: the base can back other workspaces too, e.g. when integrating the SC Editor.
  • No behavior change.

Before the change:
before

After the change:

after

Test:

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@aem-code-sync

aem-code-sync Bot commented Jun 9, 2026

Copy link
Copy Markdown

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch.
In case there are problems, just click the checkbox below to rerun the respective action.

  • Re-sync branch
Commits

@anfibiacreativa anfibiacreativa left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but the tests are failing

@anfibiacreativa anfibiacreativa self-requested a review June 10, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants