fix: handle section metadata for live preview, quick-edit and experience workspace#971
Open
usman-khalid wants to merge 4 commits into
Open
fix: handle section metadata for live preview, quick-edit and experience workspace#971usman-khalid wants to merge 4 commits into
usman-khalid wants to merge 4 commits into
Conversation
Contributor
|
Suggest to have this rendered directly in HTML like pipeline, see adobe/da-universal#222 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Section metadata is not being applied in DA's built-in live preview, Quick Edit and the Experience Workspace layout mode for sites that don't have client-side section-metadata processing, regardless of whether server side processing via helix-html-pipeline is auto-enabled (site created after May 1st, 2026) or via feature flag
features.rendering.version: 2. All three generate their preview HTML viaprose2aem, so we need to handle it there.How Has This Been Tested?
Tested on https://sm-fix--da-live--usman-khalid.aem.page/ and directly on da.live with browser overrides for all three cases (quick-edit, EW, DA live preview)
Screenshots (if appropriate):
Before (EW):

After:

Also removes
section-metadatafrom the page outline right rail in experience workspace as it's not a real block.Types of changes
Checklist: