feat: add skills editor page with ew provider block#949
Open
anfibiacreativa wants to merge 2 commits into
Open
feat: add skills editor page with ew provider block#949anfibiacreativa wants to merge 2 commits into
anfibiacreativa wants to merge 2 commits into
Conversation
Adds /apps/skills as a da-live page that renders the ew-skills block. loadBlock resolves the ew- prefix via providers.ew to load the skills editor from ew-extensions (da-skills) instead of da-nx. Co-authored-by: Cursor <cursoragent@cursor.com>
loadBlock needs providers.ew to resolve ew-* blocks (like ew-skills) to the ew-extensions AEM site. Without this, the provider lookup returns undefined and the block fails to load. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
@anfibiacreativa @hannessolo IHMO this can be closed, not needed any more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apps/skills.mdas the/apps/skillspage in da-liveew-skillsblock class soloadBlockresolves viaproviders.ewto ew-extensions (da-skills)Why
providers.ewrouting inloadBlock, but the consumer page needs theew-prefix for the resolution to worknx-skills-editorclass pointed at a block that no longer exists in da-nxWhat Changed
apps/skills.md(new file) -- page shell with<div class="ew-skills"></div>soloadBlockmatches theewprovider and loadsblocks/skills/skills.jsfrom ew-extensionsTest Plan
ew-provider-support-v2), da-skills (:3001)http://localhost:3000/apps/skills?nx=local&nxver=2#/{org}/{site}:3001/blocks/skills/skills.jscontent.da.live/adobe/da-live/apps/skillsto useew-skillsRisks / Follow-ups
content.da.livestill serves the oldnx-skills-editorclass. Until that authored page is updated, the AEM CLI dev server will serve stale content from the remote mount, not this local file.providers.ewsupportew-block-contractbranch forblocks/skills/skills.jsentry point