fix: await flushSave on WebSocket close to prevent data loss#165
Closed
kptdobe wants to merge 1 commit into
Closed
fix: await flushSave on WebSocket close to prevent data loss#165kptdobe wants to merge 1 commit into
kptdobe wants to merge 1 commit into
Conversation
…onnect Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Signed-off-by: kptdobe <acapt@adobe.com>
Contributor
Author
|
Superseded by #172 which consolidates all DO best-practice fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`webSocketClose` and `webSocketError` were synchronous but called `handleWebSocketClose` → `closeConn` which is async and does `await doc.flushSave()` on the last connection. Without the await, pending document saves are silently dropped when the last client disconnects.
Changes
🤖 Generated with Claude Code