feat: support Helix backend#160
Merged
Merged
Conversation
When x-forwarded-host === api.aem.live then use api.aem.live as backend storage instead of da-admin.
tripodsan
reviewed
May 28, 2026
Comment on lines
+299
to
+305
| } else { | ||
| const blob = new Blob([content], { type: mimeType }); | ||
| const formData = new FormData(); | ||
| formData.append('data', blob); | ||
| putBody = formData; | ||
| bodySize = blob.size; | ||
| } |
Contributor
There was a problem hiding this comment.
I thought that da admin now supports raw post bodies?
Contributor
Author
There was a problem hiding this comment.
Maybe it does, but I think the switch to that should be a different PR. This PR keeps everything the same for accessing da-admin.
tripodsan
reviewed
May 28, 2026
Comment on lines
+25
to
+28
| export function getFetchObj(isHelix, daadmin) { | ||
| return isHelix ? globalThis : daadmin; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
It never made it. I have no clue if calling da-admin via our own fetch is better than using worker bindings. This would need to be tested more deeply.
Replace the isHelix flag — threaded through get/put/update/bindState/ getYDoc/setupWSConnection/handleWebSocketMessage, an X-is-helix header, and the DocRoom hibernation attachment — with a single getBackend(docName, daadmin) resolver plus an isHelixDoc(docName) predicate. The backend is a pure function of the doc URL, so each call site derives it locally rather than transporting a boolean. getBackend encapsulates fetch routing and PUT request building; the auth-actions default is inlined at its one use site in DocRoom (a DocRoom concern, not a storage-backend one). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
kptdobe
approved these changes
Jun 5, 2026
adobe-bot
pushed a commit
that referenced
this pull request
Jun 8, 2026
# [1.7.0](v1.6.0...v1.7.0) (2026-06-08) ### Features * support Helix backend ([#160](#160)) ([b62a603](b62a603))
Collaborator
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When document host is
api.aem.liveuse Helix as backend storage instead of da-admin.Types of changes
Checklist: