feat: allow read-only connections to write comment data#132
Closed
usman-khalid wants to merge 1 commit into
Closed
feat: allow read-only connections to write comment data#132usman-khalid wants to merge 1 commit into
usman-khalid wants to merge 1 commit into
Conversation
10 tasks
10 tasks
auniverseaway
requested changes
May 18, 2026
auniverseaway
left a comment
auniverseaway
left a comment
Member
There was a problem hiding this comment.
I'm just seeing this PR. We should not be letting read-only users be able to write any part of the document. Read only should always be read-only. I thought we had landed on putting all the comments somewhere like /.da/comments or something.
I'd say: if we absolutely have to do something like this, we should do it correctly with a discussion amongst the team to decide how to handle the use case. I'm not a big fan of having a one-off backdoor in collab that fundamentally changes what "read only" actually means.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows read-only users to write only comment data.
Should be merged with adobe/da-live#882