feat(source): accept raw body PUT/POST for application/json#294
Draft
shsteimer wants to merge 2 commits into
Draft
feat(source): accept raw body PUT/POST for application/json#294shsteimer wants to merge 2 commits into
shsteimer wants to merge 2 commits into
Conversation
Previously only text/html was handled by the raw body path in putHelper; application/json (and any other non-form, non-media SUPPORTED_TYPE) fell through to undefined and was silently dropped. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
shsteimer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
putHelperonly passed raw-body requests torawBodyPutHandlerwhenContent-Typewastext/html. Any other type (e.g.application/json) fell through toundefinedand was silently dropped, causing non-HTML file uploads via raw PUT/POST to fail without an error. See adobe/helix-cli#2743.The check is replaced with
SUPPORTED_TYPES.includes(contentType) && !MEDIA_TYPES.includes(contentType), which covers bothtext/htmlandapplication/jsonusing the existing constants. This supersedes adobe/helix-cli#2744, making that change unnecessary.docs/openapi/source-api.yamlis also updated to document thePUToperation (accepted but previously undocumented) and to reflect that raw body is supported alongsidemultipart/form-datafor both methods. Note: it's unclear how changes to that file get published to https://docs.da.live/developers/api/source — the site appears to be DA-authored content rather than generated from this repo.Note for reviewers:
DA auth > test get child rulesis failing onmainprior to this PR (Set.prototype.intersectionnot available in Node 20). Not introduced here and not addressed here — leaving it for a separate fix.