Skip to content

[b49b2e] Editorial changes to note to better align with new WAI Style Guide#2415

Open
daniel-montalvo wants to merge 1 commit into
developfrom
wai-website-publication-review
Open

[b49b2e] Editorial changes to note to better align with new WAI Style Guide#2415
daniel-montalvo wants to merge 1 commit into
developfrom
wai-website-publication-review

Conversation

@daniel-montalvo
Copy link
Copy Markdown
Collaborator

Better alignment with WAI Style Guide

Based on WAI Staff comments.

Need for Call for Review:
This can be merged with 1 approval -- small editorial changes to already approved note


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".
  • If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@daniel-montalvo daniel-montalvo self-assigned this May 25, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented May 25, 2026

Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 34a7cda
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6a148e494aa8520008754ee9
😎 Deploy Preview https://deploy-preview-2415--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

Headings that are visible but not in the accessibility tree are a failure of [Success Criterion 1.3.1 Info and Relationships][sc131]. These are not tested by this rule but they can still fail [Success Criterion 2.4.6 Headings and Labels][sc246].

Testing tools treat empty headings `<h1></h1>` or `div role="heading" aria-level="1"></div>` differently. Some fail empty headings under 1.3.1, others under 2.4.6, while others pass these headings because they are ignored by most assistive technologies causing no accessibility barriers at all. This rule doesn't include examples of empty headings because there is currently no harmonized approach for testing them.
Testing tools treat empty headings `<h1></h1>` or `div role="heading" aria-level="1"></div>` differently. Some report that empty headings fail under 1.3.1 Info and Relationships, others under 2.4.6 Labels or Instructions. Other tools report that these headings pass because they are ignored by most assistive technologies causing no accessibility barriers at all. This rule does not include examples of empty headings because there is currently no harmonized approach for testing them.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Testing tools treat empty headings `<h1></h1>` or `div role="heading" aria-level="1"></div>` differently. Some report that empty headings fail under 1.3.1 Info and Relationships, others under 2.4.6 Labels or Instructions. Other tools report that these headings pass because they are ignored by most assistive technologies causing no accessibility barriers at all. This rule does not include examples of empty headings because there is currently no harmonized approach for testing them.
Testing tools treat empty headings `<h1></h1>` or `div role="heading" aria-level="1"></div>` differently. Some report that empty headings fail under 1.3.1 Info and Relationships or 2.4.6 Labels or Instructions. Other tools report that these headings pass because they are ignored by most assistive technologies and cause no accessibility barriers at all. This rule does not include examples of empty headings because there is currently no harmonized approach for testing them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants