Draft
feat: honour ACESTEP_DTYPE env var on standard CUDA devices#1185
Conversation
Closed
- Add ACESTEP_DTYPE env var check in init_service_orchestrator.py for non-ROCm CUDA dtype selection (float32/float16/bfloat16 override) - Add float32-aware attention selection in init_service_loader.py: Pre-Ampere + float32 → SDPA; Pre-Ampere + float16 → eager (unchanged) - Add 7 unit tests covering the new env override and attention paths Agent-Logs-Url: https://github.com/ace-step/ACE-Step-1.5/sessions/991cf1b8-0712-4bef-a6d2-ae9e2b3bbaa2 Co-authored-by: ChuxiJ <30956809+ChuxiJ@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix ACESTEP_DTYPE checks in init_service_loader and init_service_orchestrator
feat: honour ACESTEP_DTYPE env var on standard CUDA devices
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ACESTEP_DTYPEwas read nowhere — the env var existed but had no effect on standard (non-ROCm) CUDA paths, leaving users with no way to override the hardware-inferred dtype.Changes
init_service_orchestrator.pyelif resolved_device == "cuda"branch, checkACESTEP_DTYPEbefore hardware auto-detection.float32 | float16 | bfloat16; invalid/unset values fall through to the existing Ampere/Pre-Ampere detection unchanged.init_service_loader.py_load_main_model_from_checkpointnow checksself.dtypebefore selecting attention implementation.float32→sdpa(no overflow risk in SDPA's fused softmax with float32).float16(default on Pre-Ampere) →eagerworkaround retained unchanged.Tests
init_service_test.pycovering: all three validACESTEP_DTYPEvalues, invalid/unset fallback, and the float32 vs float16 attention-selection paths on Pre-Ampere CUDA.