fix: throw proper exception for nonexistent Scalar plugin methods#394
Draft
toddr-bot wants to merge 1 commit intoabw:masterfrom
Draft
fix: throw proper exception for nonexistent Scalar plugin methods#394toddr-bot wants to merge 1 commit intoabw:masterfrom
toddr-bot wants to merge 1 commit intoabw:masterfrom
Conversation
When calling a nonexistent method via the scalar monad (e.g. object.scalar.no_such_method), the code called can() which returned undef, then tried to use undef as a code reference. This produced a cryptic Perl error: undef error - Can't use an undefined value as a subroutine reference Now throws a proper Template::Exception: scalar error - no such method: no_such_method Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix the Scalar plugin monad to throw a typed exception when a nonexistent method is called.
Why
Calling
object.scalar.nonexistent_methodproduced a cryptic Perl internal error:This makes debugging difficult because the error type is
undef(generic) and the message reveals Perl internals rather than the actual problem.How
Added a check after
$this->can($item): if the method doesn't exist, throw aTemplate::Exceptionof typescalarwith a clear message (no such method: <name>). This matches the pattern used when calling scalar methods on non-objects (line 104).Testing
Added a test case to t/scalar.t that calls a nonexistent method via the scalar monad and verifies the proper exception type and message.
🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 9 insertions(+), 1 deletion(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline