fix: escape quotes in Dumper dump_html and document all options#392
Draft
toddr-bot wants to merge 1 commit intoabw:masterfrom
Draft
fix: escape quotes in Dumper dump_html and document all options#392toddr-bot wants to merge 1 commit intoabw:masterfrom
toddr-bot wants to merge 1 commit intoabw:masterfrom
Conversation
…bw#195) dump_html() was missing quote escaping — single and double quotes were passed through unescaped, inconsistent with the html_filter which escapes both (" → ", ' → &abw#39;). This could cause issues when dump output appears in HTML attribute contexts. Also updates the POD to document all 13 supported Data::Dumper options (was only listing Pad, Indent, Varname). Closes GH abw#195. Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds quote escaping to
dump_html()and documents all 13 supported Data::Dumper options in the POD.Why
dump_html()escaped&,<,>but not"or'— inconsistent with the project's ownhtml_filterwhich escapes all five. While Dumper output is typically used in text contexts, proper escaping prevents issues in attribute contexts.How
s/"/"/gands/'/'/gtodump_html(), matchinghtml_filter's escaping.@DUMPER_ARGS.Testing
t/dumper.tpasses (17/17). Test 4 assertion updated for escaped quotes indump_htmloutput.🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 11 insertions(+), 4 deletions(-)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline