fix: use instance DOCUMENT class instead of package global (GH #173)#377
Draft
toddr-bot wants to merge 1 commit intoabw:masterfrom
Draft
fix: use instance DOCUMENT class instead of package global (GH #173)#377toddr-bot wants to merge 1 commit intoabw:masterfrom
toddr-bot wants to merge 1 commit intoabw:masterfrom
Conversation
Provider._store() used $self->{DOCUMENT} for write_perl_file() but
the same method used the package global $DOCUMENT for new(). This
meant a custom DOCUMENT class passed to the Provider constructor
was silently ignored when creating document objects from parsed
templates.
Co-Authored-By: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$self->{DOCUMENT}instead of the package global$DOCUMENTwhen constructing document objects from parsed templates.$self->{DOCUMENT}but never used for->new()— the global$DOCUMENTwas called instead, silently ignoring the custom class. The same method already uses$self->{DOCUMENT}forwrite_perl_file(), making this inconsistency clear.fetch()returns objects of that class.Closes #173
Test plan
🤖 Generated with Claude Code