fix: make stderr filter test locale-independent (GH #303)#354
Open
toddr-bot wants to merge 1 commit intoabw:masterfrom
Open
fix: make stderr filter test locale-independent (GH #303)#354toddr-bot wants to merge 1 commit intoabw:masterfrom
toddr-bot wants to merge 1 commit intoabw:masterfrom
Conversation
The stderr template variable accumulated ALL STDERR output since the tie started. On systems with locale warnings (e.g., Japanese_Japan.932 on Windows), Perl emits warnings that pollute the captured STDERR, causing the test to fail. Change the stderr accessor to read-and-clear so each test assertion sees only what was written since the last read, not accumulated noise. Co-Authored-By: Claude Opus 4.6 <[email protected]>
atoomic
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The stderr filter test in
t/filter.tno longer fails on systems with locale warnings.Why
On Windows with locales like
Japanese_Japan.932, Perl emits a warning to STDERRduring startup/processing. The test tied STDERR to a variable and accumulated
everything — including these warnings — then compared against the expected
filter output. The accumulated warnings caused a mismatch. Fixes #303.
How
Changed the
stderrtemplate variable from a simple getter to a read-and-clearaccessor. Each
[% stderr %]call now drains the buffer, so assertions seeonly what was written since the last read — not accumulated noise from earlier
tests or Perl internals.
Testing
All 164 filter tests pass. The change is backward-compatible since no test
reads
[% stderr %]more than once per test block.🤖 Generated with Claude Code