Skip to content

Send the tenant connection string in the request body - #26049

Merged
ismcagdas merged 3 commits into
rel-10.7from
maliming/tenant-connection-string-in-body
Aug 24, 2026
Merged

Send the tenant connection string in the request body#26049
ismcagdas merged 3 commits into
rel-10.7from
maliming/tenant-connection-string-in-body

Conversation

@maliming

Copy link
Copy Markdown
Member

Depends on #26048

The tenant connection string was a query string parameter of UpdateDefaultConnectionStringAsync, so it was written to web server access logs. It is sent in the request body now, and the Angular proxy generator emits a JSON string body with the application/json content type for string parameters.

DisableAuditingAttribute can now be used on method parameters
It was a query string parameter, so it was written to web server access logs
Angular sends a plain string body as text/plain, which the endpoint rejects
Copilot AI lite review requested due to automatic review settings August 24, 2026 03:58

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Aug 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.19%. Comparing base (ccd673c) to head (bb4f483).
⚠️ Report is 4 commits behind head on rel-10.7.

Additional details and impacted files
@@             Coverage Diff              @@
##           rel-10.7   #26049      +/-   ##
============================================
- Coverage     49.20%   49.19%   -0.01%     
============================================
  Files          3806     3806              
  Lines        132482   132496      +14     
  Branches      10043    10045       +2     
============================================
- Hits          65194    65188       -6     
- Misses        65328    65362      +34     
+ Partials       1960     1946      -14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming
maliming requested a review from enisn August 24, 2026 04:50
@maliming maliming added this to the 10.7-final milestone Aug 24, 2026
@ismcagdas
ismcagdas merged commit b80ec2f into rel-10.7 Aug 24, 2026
4 of 7 checks passed
@ismcagdas
ismcagdas deleted the maliming/tenant-connection-string-in-body branch August 24, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants