Skip to content

Hash the connection string in unit of work api keys - #26047

Merged
EngincanV merged 2 commits into
rel-10.7from
maliming/uow-api-key-connection-string
Aug 24, 2026
Merged

Hash the connection string in unit of work api keys#26047
EngincanV merged 2 commits into
rel-10.7from
maliming/uow-api-key-connection-string

Conversation

@maliming

Copy link
Copy Markdown
Member

Resolve #26044

The database and transaction api keys of the EF Core, MongoDB and MemoryDb providers contained the resolved connection string, so it reached the logs whenever the key was part of an exception message. The second commit is an unrelated allocation cleanup of ToMd5, ToSha256 and ToSha512.

Copilot AI lite review requested due to automatic review settings August 23, 2026 12:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@maliming maliming added this to the 10.7-final milestone Aug 23, 2026
@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 26.50602% with 61 lines in your changes missing coverage. Please review.
✅ Project coverage is 49.18%. Comparing base (ccd673c) to head (3945a91).
⚠️ Report is 4 commits behind head on rel-10.7.

Files with missing lines Patch % Lines
...eworkCore/Uow/UnitOfWorkDbContextProvider_Tests.cs 0.00% 30 Missing ⚠️
...ryDb/Uow/UnitOfWorkMemoryDatabaseProvider_Tests.cs 0.00% 16 Missing ⚠️
...lo.Abp.Core.Tests/System/StringExtensions_Tests.cs 0.00% 9 Missing ⚠️
...bp/Uow/MongoDB/UnitOfWorkMongoDbContextProvider.cs 70.00% 2 Missing and 1 partial ⚠️
...p/Uow/MemoryDb/UnitOfWorkMemoryDatabaseProvider.cs 60.00% 1 Missing and 1 partial ⚠️
...EntityFrameworkCore/UnitOfWorkDbContextProvider.cs 90.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           rel-10.7   #26047      +/-   ##
============================================
- Coverage     49.20%   49.18%   -0.03%     
============================================
  Files          3806     3808       +2     
  Lines        132482   132527      +45     
  Branches      10043    10047       +4     
============================================
- Hits          65194    65189       -5     
- Misses        65328    65390      +62     
+ Partials       1960     1948      -12     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maliming
maliming requested review from EngincanV and a lite review from Copilot August 24, 2026 01:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@maliming
maliming requested review from EngincanV and enisn and removed request for EngincanV and enisn August 24, 2026 04:50
@EngincanV
EngincanV merged commit 39a6bad into rel-10.7 Aug 24, 2026
2 of 4 checks passed
@EngincanV
EngincanV deleted the maliming/uow-api-key-connection-string branch August 24, 2026 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants