Hash the connection string in unit of work api keys - #26047
Merged
Conversation
The api key can be written to logs as a part of an exception message
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## rel-10.7 #26047 +/- ##
============================================
- Coverage 49.20% 49.18% -0.03%
============================================
Files 3806 3808 +2
Lines 132482 132527 +45
Branches 10043 10047 +4
============================================
- Hits 65194 65189 -5
- Misses 65328 65390 +62
+ Partials 1960 1948 -12 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
EngincanV
approved these changes
Aug 24, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #26044
The database and transaction api keys of the EF Core, MongoDB and MemoryDb providers contained the resolved connection string, so it reached the logs whenever the key was part of an exception message. The second commit is an unrelated allocation cleanup of
ToMd5,ToSha256andToSha512.