Repository navigation
fix(boilingcore): stop go.mod search at filesystem root - #1485
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1479.
The
go.modancestor search stopped on/and., but a Windows drive root is stable underfilepath.Dir(for example,filepath.Dir("C:\\") == "C:\\"). When nogo.modexists, the loop therefore never terminates. Stop when the parent path equals the current path, and cover the Windows root case with a focused regression test.Validation on Windows with Go 1.26.3:
go test -mod=readonly -run '^TestFindGoModPathStopsAtFilesystemRoot$' -count=1 -timeout=8s ./boilingcore— passed.gofmtandgit diff --check— passed.go test -mod=readonly -short ./boilingcore— does not pass on this Windows host: the existingTestOutputFilenamePartspanics on slash-delimited fixtures becauseoutputFilenamePartssplits using the native path separator. Those files are unchanged and the failure is unrelated to this patch.No database or external application service was used.