feat(language-switcher): Implement new language and theme switcher menus - #807
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 999606bbeb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| user: AvatarUser & { email: string }; | ||
| }) => ( | ||
| <> | ||
| <Avatar className="size-8" size={32} user={user} /> |
There was a problem hiding this comment.
When an authenticated visitor opens either user menu, this Avatar contributes alt={user.name} immediately before a visible span containing the same name, causing screen readers to announce the identity twice. Mark this avatar instance aria-hidden or otherwise give it empty alt text because the image is repetitive.
AGENTS.md reference: AGENTS.md:L54-L55
Useful? React with 👍 / 👎.
| <div className="grid flex-1 text-start text-sm leading-tight"> | ||
| <span className="truncate font-medium">{user.name}</span> | ||
| <span className="text-muted-foreground truncate text-xs"> |
There was a problem hiding this comment.
For every authenticated user, the new identity block renders the email with text-xs (12px) and applies leading-tight to both lines, below the repository's required 14px minimum and 1.4–1.6 line height. Use at least text-sm and leading-relaxed so this newly exposed account text remains readable.
AGENTS.md reference: AGENTS.md:L70-L70
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1dfd08257a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| return ( | ||
| <RouterLink className={className} href={href}> | ||
| <Link<RegisteredRouter, string, string> className={className} href={href}> |
There was a problem hiding this comment.
to
In newly generated applications, the internal Register and AdminCP cards pass their destination as the native href prop, but TanStack Router builds Link navigation from to; with to omitted, these cards resolve against the current route instead of navigating to href. The hero buttons above use the correct to={...} form, and this card should do the same.
Useful? React with 👍 / 👎.
| { Icon: MonitorIcon, value: "system" }, | ||
| ] as const; | ||
|
|
||
| export const ThemeSwitcherMenu = () => { |
There was a problem hiding this comment.
This patch introduces a new theme/language preference workflow and relocates those controls into the account and AdminCP menus, but it adds no user or developer documentation for the feature. Add concise documentation explaining where the controls live and what the light, dark, and system choices do, as required for every new feature.
AGENTS.md reference: AGENTS.md:L75-L75
Useful? React with 👍 / 👎.
1 participant
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?