feat: Add overview settings with personal info - #806
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
aXenDeveloper
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 961aa8b46d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| async input => { | ||
| const result = await updatePersonalInformationInBrowser(input); | ||
|
|
||
| if (result.data) await invalidateSession(queryClient); |
There was a problem hiding this comment.
When a user changes firstName, lastName, or showRealName, this success path invalidates only the session query. The settings loader has already cached userProfileQuery(nameCode) with staleTime: "static", so opening the user's profile through client-side navigation continues to show the old public name until a full reload. Invalidate userProfileQueryKey(nameCode) alongside the session so the profile reflects the saved details immediately.
AGENTS.md reference: AGENTS.md:L45-L50
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0ddc20808
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| name: displayNameOf({ | ||
| ...user, | ||
| showRealName: | ||
| c.get("core").personalInformationFields.showRealName && | ||
| user.showRealName, |
There was a problem hiding this comment.
When an installation disables firstName or lastName after users have populated them, but leaves showRealName enabled, this passes both retained columns to displayNameOf and continues publishing the disabled value. The field simultaneously disappears from the member's settings form, so they cannot clear the information that remains public. Gate each name component with its corresponding personalInformationFields flag, as is already done for headline below.
Useful? React with 👍 / 👎.
| className={cn( | ||
| "flex-1 text-sm outline-none", | ||
| "transition-[opacity,translate] duration-500 ease-[cubic-bezier(0.22,1,0.36,1)] motion-reduce:transition-none", | ||
| "data-ending-style:absolute data-ending-style:inset-x-0 data-ending-style:top-0", |
There was a problem hiding this comment.
When switching between emoji and icon modes, the existing EmojiIconPickerPanel renders TabsContent directly under Tabs without the new TabsPanels wrapper. This rule therefore makes the exiting picker absolute against the popover rather than the wrapper's relative content box, placing it at the top of the popup over the tab controls and allowing the slide transition to spill outside the intended viewport. Either keep the default TabsContent static unless it is inside TabsPanels, or update every existing consumer before applying this positioning globally.
Useful? React with 👍 / 👎.
1 participant
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?