perf: Improve Tanstack Start components - #802
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…` in multiple components
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ba281c6e85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <RouterLink | ||
| <Link<RegisteredRouter, string, string> | ||
| className="text-muted-foreground hover:text-foreground text-sm transition-colors" | ||
| href={href} |
There was a problem hiding this comment.
Pass footer destinations through
to
Every entry in the footer columns now renders a TanStack Router Link with href but no to. TanStack Router derives and writes the anchor destination from to, so these links resolve to the current location instead of the configured paths; clicking Documentation, Plugins, Solutions, and the other footer entries therefore does not navigate to the intended page. Use to for these internal destinations.
Useful? React with 👍 / 👎.
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?