perf: Replace clsx to cn - #794
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 39697f6905
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return context; | ||
| }; | ||
| import { useDashboardBoard } from "./board-context"; | ||
| import { WidgetSettingsDialogContext } from "./widget-settings-context"; |
There was a problem hiding this comment.
When an installed plugin's settingsComponent imports useWidgetSettingsDialog from @vitnode/core/views/admin/views/core/dashboard/grid/widget-settings-dialog, upgrading core now fails because that module no longer exports the hook. The settings component receives only settings and widgetId, so this hook is its mechanism for saving through the surrounding dialog; moving it requires preserving a re-export from the old module for existing plugins.
Useful? React with 👍 / 👎.
| return twMerge(clsx(inputs)); | ||
| } | ||
|
|
||
| export const normalizeUrl = (url: string) => |
There was a problem hiding this comment.
When an existing app or plugin imports cn from @vitnode/core/lib/utils, this release causes a missing named-export error because the wildcard package export still exposes the module but cn has been deleted from it. The repository's web app used this exact public path before being migrated in this commit, so external consumers can reasonably have the same import; re-exporting the new package implementation here preserves compatibility without losing the optimization.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fc00731ac8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13b8655b4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| import type { DashboardLayoutAction } from "./layout-reducer"; | ||
|
|
||
| import { widgetIdOf } from "../widgets/instance-id"; | ||
| import { DashboardBoardContext } from "./board-context"; |
There was a problem hiding this comment.
When an existing plugin imports useDashboardBoard from @vitnode/core/views/admin/views/core/dashboard/grid/board-provider, upgrading core now produces a missing-export error because the hook was moved to board-context without a compatibility re-export. The package's wildcard export exposes this module publicly, and plugin widget components rendered below DashboardBoardProvider can use the hook, so keep a re-export from the original path.
Useful? React with 👍 / 👎.
This branch was successfully deployed
1 participant
Improving Documentation
pnpm lint:fixto fix formatting issues before opening the PR.Description
What?
Why?