Invalidate prepared point cache on new setup#19
Merged
Conversation
90b233a to
0dda701
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent stale Arkworks prepared-point caching by invalidating the global prepared-point cache when a new setup is persisted, ensuring subsequent operations don’t accidentally reuse prepared points from an old setup.
Changes:
- Add
invalidate_cache()to the Arkworks prepared-point cache implementation. - Re-export
invalidate_cache()from the Arkworks backend module whencacheis enabled. - Call
invalidate_cache()after saving setups to disk (behindcfg(feature = "cache")).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/setup.rs |
Invalidates Arkworks prepared-point cache after persisting a setup. |
src/backends/arkworks/mod.rs |
Re-exports invalidate_cache under the cache feature. |
src/backends/arkworks/ark_cache.rs |
Implements invalidate_cache() to clear the global prepared cache. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
0dda701 to
d2227fd
Compare
Collaborator
|
lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.