Skip to content

fix(pos): label Order action "Request payment" instead of "Pay" (#2696)#4159

Open
Wajid-0ne wants to merge 1 commit into
ZeusLN:masterfrom
Wajid-0ne:fix/2696-pos-request-payment
Open

fix(pos): label Order action "Request payment" instead of "Pay" (#2696)#4159
Wajid-0ne wants to merge 1 commit into
ZeusLN:masterfrom
Wajid-0ne:fix/2696-pos-request-payment

Conversation

@Wajid-0ne

Copy link
Copy Markdown

Description

Relates to issue: ZEUS-#2696

In the Point of Sale Order view, the primary action button was labelled "Pay"
(general.pay). That button does not pay anything, it navigates to the
Receive / ReceiveEcash screen with autoGenerate: true to generate an
invoice for the customer, i.e. the merchant is requesting payment. The label
was therefore misleading.

This PR relabels the button to "Request payment". A new locale key
pos.views.Order.requestPayment is added to locales/en.json (English source)
and used in views/Order.tsx. Non-English locales fall back to the English
string until translated via Transifex.

This pull request is categorized as a:

  • New feature
  • Bug fix
  • Code refactor
  • Configuration change
  • Locales update
  • Quality assurance
  • Other

Checklist

  • I’ve run yarn run tsc and made sure my code compiles correctly
  • I’ve run yarn run lint and made sure my code didn’t contain any problematic patterns
  • I’ve run yarn run prettier and made sure my code is formatted correctly
  • I’ve run yarn run test and made sure all of the tests pass

Testing

If you modified or added a utility file, did you add new unit tests?

  • No, I’m a fool
  • Yes
  • N/A

I have tested this PR on the following platforms (please specify OS version and phone model/VM):

  • Android
  • iOS

I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):

On-device

  • LDK Node
  • Embedded LND

Remote

  • LND (REST)
  • LND (Lightning Node Connect)
  • Core Lightning (CLNRest)
  • Nostr Wallet Connect
  • LndHub

Locales

  • I’ve added new locale text that requires translations
  • I’m aware that new translations should be made on the ZEUS Transfix page and not directly to this repo

Third Party Dependencies and Packages

  • Contributors will need to run yarn after this PR is merged in
  • 3rd party dependencies have been modified:
    • verify that package.json and yarn.lock have been properly updated
    • verify that dependencies are installed for both iOS and Android platforms

Other:

  • Changes were made that require an update to the README
  • Changes were made that require an update to onboarding

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the button title in the Order view from 'general.pay' to a more specific translation key 'pos.views.Order.requestPayment', and adds the corresponding translation string 'Request payment' to the English locale file. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@Wajid-0ne

Copy link
Copy Markdown
Author

@kaloudis please review and advise

@shubhamkmr04 shubhamkmr04 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@kaloudis

Copy link
Copy Markdown
Contributor

I'm torn on this one. If the device is presented to the user at this point - where you allow them to enter the tip or see their itemized bill - then the "Pay" label here makes sense @myxmaster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants