fix(pos): label Order action "Request payment" instead of "Pay" (#2696)#4159
fix(pos): label Order action "Request payment" instead of "Pay" (#2696)#4159Wajid-0ne wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the button title in the Order view from 'general.pay' to a more specific translation key 'pos.views.Order.requestPayment', and adds the corresponding translation string 'Request payment' to the English locale file. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
@kaloudis please review and advise |
|
I'm torn on this one. If the device is presented to the user at this point - where you allow them to enter the tip or see their itemized bill - then the "Pay" label here makes sense @myxmaster |
Description
Relates to issue: ZEUS-#2696
In the Point of Sale Order view, the primary action button was labelled "Pay"
(
general.pay). That button does not pay anything, it navigates to theReceive/ReceiveEcashscreen withautoGenerate: trueto generate aninvoice for the customer, i.e. the merchant is requesting payment. The label
was therefore misleading.
This PR relabels the button to "Request payment". A new locale key
pos.views.Order.requestPaymentis added tolocales/en.json(English source)and used in
views/Order.tsx. Non-English locales fall back to the Englishstring until translated via Transifex.
This pull request is categorized as a:
Checklist
yarn run tscand made sure my code compiles correctlyyarn run lintand made sure my code didn’t contain any problematic patternsyarn run prettierand made sure my code is formatted correctlyyarn run testand made sure all of the tests passTesting
If you modified or added a utility file, did you add new unit tests?
I have tested this PR on the following platforms (please specify OS version and phone model/VM):
I have tested this PR with the following types of nodes (please specify node version and API version where appropriate):
On-device
Remote
Locales
Third Party Dependencies and Packages
yarnafter this PR is merged inpackage.jsonandyarn.lockhave been properly updatedOther: