Skip to content

scripts: πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in feeds update - #249

Merged
manupawickramasinghe merged 1 commit into
mainfrom
sentinel-fix-feeds-cmd-injection-2887205039955759445
Jul 28, 2026
Merged

scripts: πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in feeds update#249
manupawickramasinghe merged 1 commit into
mainfrom
sentinel-fix-feeds-cmd-injection-2887205039955759445

Conversation

@ManupaKDU

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Unquoted variable interpolation in a system() shell command in scripts/feeds.
🎯 Impact: An attacker who controls a feed name could inject arbitrary shell commands during feed initialization. Specifically, $safename and $localpath_orig were interpolated into a shell string without being enclosed in single quotes, despite having their own single quotes escaped.
πŸ”§ Fix: Wrapped the interpolated variables $safename, $localpath_orig, and $flags->{'root'} in single quotes within the system() call to prevent shell word splitting and injection.
βœ… Verification: Verified by manual inspection and running perl -c scripts/feeds to check syntax.


PR created automatically by Jules for task 2887205039955759445 started by @manupawickramasinghe

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@manupawickramasinghe
manupawickramasinghe merged commit 0b03e0e into main Jul 28, 2026
3 checks passed
@manupawickramasinghe
manupawickramasinghe deleted the sentinel-fix-feeds-cmd-injection-2887205039955759445 branch July 28, 2026 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants