Skip to content

ead: πŸ›‘οΈ Sentinel: [HIGH] Fix Unbounded sprintf writing to pidfile - #246

Merged
ManupaKDU merged 4 commits into
mainfrom
sentinel-ead-sprintf-fix-5997734116727649538
Jul 25, 2026
Merged

ead: πŸ›‘οΈ Sentinel: [HIGH] Fix Unbounded sprintf writing to pidfile#246
ManupaKDU merged 4 commits into
mainfrom
sentinel-ead-sprintf-fix-5997734116727649538

Conversation

@ManupaKDU

Copy link
Copy Markdown

🚨 Severity: HIGH
πŸ’‘ Vulnerability: Unbounded sprintf writing process ID to a fixed-size pid array buffer.
🎯 Impact: If getpid() or an associated environmental configuration somehow generated an unexpectedly large process string, it could potentially overwrite adjacent memory resulting in a buffer overflow (though practically unlikely with modern PID limits, it breaks secure coding practices).
πŸ”§ Fix: Changed sprintf(pid, "%d\n", getpid()) to snprintf(pid, sizeof(pid), "%d\n", getpid()), ensuring bounds-checking protects the 32-byte limit.
βœ… Verification: Compiled the logic in an isolated standalone proxy C file to ensure valid compilation, ran make help to ensure global OpenWrt syntax parsing wasn't impacted, and executed git status + git diff to confirm precise modifications.


PR created automatically by Jules for task 5997734116727649538 started by @manupawickramasinghe

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
google-labs-jules Bot and others added 2 commits July 25, 2026 16:48
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@ManupaKDU
ManupaKDU merged commit a94d4db into main Jul 25, 2026
238 of 312 checks passed
@ManupaKDU
ManupaKDU deleted the sentinel-ead-sprintf-fix-5997734116727649538 branch July 25, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant