ead: π‘οΈ Sentinel: [HIGH] Fix Unbounded sprintf writing to pidfile - #246
Conversation
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
Signed-off-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com> Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
π¨ Severity: HIGH
π‘ Vulnerability: Unbounded
sprintfwriting process ID to a fixed-sizepidarray buffer.π― Impact: If
getpid()or an associated environmental configuration somehow generated an unexpectedly large process string, it could potentially overwrite adjacent memory resulting in a buffer overflow (though practically unlikely with modern PID limits, it breaks secure coding practices).π§ Fix: Changed
sprintf(pid, "%d\n", getpid())tosnprintf(pid, sizeof(pid), "%d\n", getpid()), ensuring bounds-checking protects the 32-byte limit.β Verification: Compiled the logic in an isolated standalone proxy C file to ensure valid compilation, ran
make helpto ensure global OpenWrt syntax parsing wasn't impacted, and executedgit status+git diffto confirm precise modifications.PR created automatically by Jules for task 5997734116727649538 started by @manupawickramasinghe