π‘οΈ Sentinel: [HIGH] Fix JPQL injection in FormFormatController - #199
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: JPQL Injection via raw string concatenation in
FormFormatController.getSelectedItems().π― Impact: Malicious user input could alter the structure of the database query, potentially leading to data extraction or unauthorized access.
π§ Fix: Replaced raw string concatenation with a parameterized JPQL query using
:qand passinggetSelectText().toUpperCase()in the parameter map. Includedupper(c.name)to maintain case-insensitive search logic safely.β Verification: Tested the fix locally;
mvn testpasses completely. Code review confirms the security fix mitigates the injection risk.PR created automatically by Jules for task 5658558541449921834 started by @manupawickramasinghe