Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix JPQL injection in BillFeeController - #198

Merged
ManupaKDU merged 1 commit into
developmentfrom
sentinel-fix-jpql-injection-billfeecontroller-6495502925685113247
Jul 30, 2026
Merged

πŸ›‘οΈ Sentinel: [CRITICAL] Fix JPQL injection in BillFeeController#198
ManupaKDU merged 1 commit into
developmentfrom
sentinel-fix-jpql-injection-billfeecontroller-6495502925685113247

Conversation

@ManupaKDU

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: JPQL Injection vulnerability in BillFeeController.java (getSelectedItems) due to unsafe string concatenation using like '%" + getSelectText().toUpperCase() + "%'.
🎯 Impact: An attacker could potentially inject malicious JPQL/SQL syntax into the selectText search field, allowing them to manipulate the database query, bypass logic, or access unauthorized data.
πŸ”§ Fix: Refactored the JPQL query to use parameterized inputs (:qry) and pass the selectText via a Map<String, Object>, ensuring the input is properly escaped and bound by the ORM. Also improved logic by using upper(c.name) in the query to guarantee case-insensitive matching.
βœ… Verification: Ran full test suite via ./detect-maven.sh test which passed successfully. Verified that the getSelectedItems method executes parameterized queries correctly.


PR created automatically by Jules for task 6495502925685113247 started by @manupawickramasinghe

Refactored `getSelectedItems` method to use parameterized queries instead of string concatenation, preventing SQL/JPQL injection vulnerabilities when searching for bill fees by name.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ManupaKDU
ManupaKDU merged commit e5b6539 into development Jul 30, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant