π‘οΈ Sentinel: [CRITICAL] Fix JPQL injection in BillFeeController - #198
Conversation
Refactored `getSelectedItems` method to use parameterized queries instead of string concatenation, preventing SQL/JPQL injection vulnerabilities when searching for bill fees by name. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: JPQL Injection vulnerability in
BillFeeController.java(getSelectedItems) due to unsafe string concatenation usinglike '%" + getSelectText().toUpperCase() + "%'.π― Impact: An attacker could potentially inject malicious JPQL/SQL syntax into the
selectTextsearch field, allowing them to manipulate the database query, bypass logic, or access unauthorized data.π§ Fix: Refactored the JPQL query to use parameterized inputs (
:qry) and pass theselectTextvia aMap<String, Object>, ensuring the input is properly escaped and bound by the ORM. Also improved logic by usingupper(c.name)in the query to guarantee case-insensitive matching.β Verification: Ran full test suite via
./detect-maven.sh testwhich passed successfully. Verified that thegetSelectedItemsmethod executes parameterized queries correctly.PR created automatically by Jules for task 6495502925685113247 started by @manupawickramasinghe