π‘οΈ Sentinel: [HIGH] Fix JPQL injection in auto-complete methods - #195
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: HIGH
π‘ Vulnerability: JPQL injection vulnerability in
GradeControllerandStaffLeaveEntitleControllerauto-complete methods due to string concatenation of user input (qry).π― Impact: Malicious users could potentially inject arbitrary JPQL into the query, bypassing security controls, altering query logic, or extracting sensitive information from the database.
π§ Fix: Refactored the
completeGradeandcompleteStaffLeaveEntitlemethods to use secure, parameterized queries with named parameters (:q) and a query parameter map.β Verification: Ran
./detect-maven.sh testwhich passed 243 tests successfully. Ensured no regressions were introduced.PR created automatically by Jules for task 2398628048851096371 started by @manupawickramasinghe