Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix JPQL injection in ServiceSessionController - #194

Merged
ManupaKDU merged 1 commit into
developmentfrom
sentinel-fix-jpql-injection-servicesessioncontroller-8940605791160143472
Jul 25, 2026
Merged

πŸ›‘οΈ Sentinel: [CRITICAL] Fix JPQL injection in ServiceSessionController#194
ManupaKDU merged 1 commit into
developmentfrom
sentinel-fix-jpql-injection-servicesessioncontroller-8940605791160143472

Conversation

@ManupaKDU

Copy link
Copy Markdown

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Unsafe string concatenation used to construct JPQL queries in ServiceSessionController.java (getSelectedItems, completeServiceSession, completeSession methods) allowed for SQL/JPQL injection attacks. Input parameters like getSelectText() and query were injected directly into the query string.
🎯 Impact: Exploitation could allow an attacker to bypass intended search functionality, extract sensitive database information, or execute unauthorized operations.
πŸ”§ Fix: Replaced string concatenation with parameterized JPQL queries using named parameters (:qry) and bound the user inputs via HashMap. Maintained case-insensitive matching by applying upper() within the JPQL string. Added inline comments to highlight the security fix.
βœ… Verification: Verified changes locally and ran the test suite. All tests pass with no new regressions. Evaluated logic to ensure functional parity with the original insecure implementation.


PR created automatically by Jules for task 8940605791160143472 started by @manupawickramasinghe

Refactored `getSelectedItems`, `completeServiceSession`, and `completeSession` methods in `ServiceSessionController.java` to use parameterized queries instead of insecure string concatenation. Used `upper(c.name)` to maintain case-insensitivity without compromising security.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ManupaKDU
ManupaKDU merged commit fbe77ad into development Jul 25, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant