π‘οΈ Sentinel: [CRITICAL] Fix JPQL injection in ChannelScheduleController - #192
Conversation
Replaced unsafe string concatenation with parameterized query in `completeSession()` to prevent JPQL injection via dynamic autocomplete search queries. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
β¦controller-6782152643201905493
π¨ Severity: CRITICAL
π‘ Vulnerability: JPQL Injection. In
ChannelScheduleController.completeSession(), user-provided input was concatenated directly into aLIKEclause:like '%" + query.toUpperCase() + "%'. This bypassed the ORM's sanitization, allowing potential injection of malicious JPQL syntax.π― Impact: An attacker could craft specific autocomplete queries to manipulate the database query logic, potentially reading unauthorized data (such as other doctors' schedules or user information) or causing denial-of-service through complex queries.
π§ Fix: Refactored the JPQL string to use named parameters (
:queryand:staffId) and utilized the JPA facade's parameterizedfindByJpql(sql, params)method. The case-insensitive search logic was moved safely into the query string via theupper()function.β Verification:
cat -n src/main/java/com/divudi/bean/channel/ChannelScheduleController.java | sed -n '680,700p')../detect-maven.sh test.PR created automatically by Jules for task 6782152643201905493 started by @manupawickramasinghe