🔒 Sentinel: [HIGH] Fix SQL Injection in DesignationController - #190
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed JPQL injection vulnerabilities in
⚠️ Risk: User-controlled input (
DesignationController.javawithin thegetSelectedItemsandcompleteDesignationmethods.getSelectText()andqry) was directly concatenated into JPQL query strings, which could allow malicious users to execute arbitrary JPQL queries, potentially exposing or modifying sensitive HR designation data.🛡️ Solution: Replaced string concatenation with safe, parameterized JPQL queries using a
Map<String, Object>. The case-insensitive search logic was preserved by utilizing the JPQLupper()function alongside parameterization. Also added the necessaryjava.util.Mapandjava.util.HashMapimports.PR created automatically by Jules for task 8951625468409297682 started by @manupawickramasinghe