Skip to content

🔒 Sentinel: [HIGH] Fix SQL injection in BookingControllerViewScope completeStaff - #189

Merged
ManupaKDU merged 1 commit into
developmentfrom
fix/booking-controller-sqli-6727759521441987663
Jul 22, 2026
Merged

🔒 Sentinel: [HIGH] Fix SQL injection in BookingControllerViewScope completeStaff#189
ManupaKDU merged 1 commit into
developmentfrom
fix/booking-controller-sqli-6727759521441987663

Conversation

@ManupaKDU

Copy link
Copy Markdown

🎯 What: Fixed an SQL injection vulnerability in BookingControllerViewScope.java where the query input was unsafely concatenated into a JPQL statement.

⚠️ Risk: An attacker could potentially inject malicious JPQL to bypass the filtering logic, retrieve sensitive information about all staff members regardless of the applied parameters, or cause denial of service.

🛡️ Solution: Replaced string concatenation with parameterized JPQL using :q. The Map securely passes the uppercase query representation, and upper() was applied to entity property names in the JPQL to maintain case-insensitive querying capabilities securely.


PR created automatically by Jules for task 6727759521441987663 started by @manupawickramasinghe

Parameterizes the JPQL query to use the `upper()` function and a Map of parameters to prevent SQL injection when retrieving Staff suggestions based on a user-provided query string.

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ManupaKDU
ManupaKDU merged commit c9691aa into development Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant