Skip to content

🔒 [CRITICAL] Fix SQL injection vulnerability in ItemController queries - #186

Merged
ManupaKDU merged 1 commit into
developmentfrom
fix-sql-injection-itemcontroller-18283260539139786552
Jul 22, 2026
Merged

🔒 [CRITICAL] Fix SQL injection vulnerability in ItemController queries#186
ManupaKDU merged 1 commit into
developmentfrom
fix-sql-injection-itemcontroller-18283260539139786552

Conversation

@ManupaKDU

Copy link
Copy Markdown

🎯 What: The vulnerability fixed
Fixed multiple instances of SQL Injection in ItemController.java where user-controlled input (query.toUpperCase()) was directly concatenated into JPQL query strings (e.g., in completeAmpAndAmppItem, completePackage, etc.).

⚠️ Risk: The potential impact if left unfixed
Direct string concatenation in JPQL queries allows attackers to inject malicious JPQL, potentially enabling unauthorized data access, exfiltration of sensitive hospital/inventory information, or denial of service by crafting resource-intensive queries.

🛡️ Solution: How the fix addresses the vulnerability
Replaced the direct string concatenation with parameterized JPQL queries using named parameters (e.g., :q). The case-insensitive matching logic was preserved by using the JPQL upper() function on the columns (e.g., upper(c.name) like :q) and passing the uppercased input into the parameter map.


PR created automatically by Jules for task 18283260539139786552 started by @manupawickramasinghe

Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@ManupaKDU
ManupaKDU merged commit 95e8be1 into development Jul 22, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant