🔒 [CRITICAL] Fix SQL injection vulnerability in ItemController queries - #186
Conversation
Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: The vulnerability fixed
Fixed multiple instances of SQL Injection in
ItemController.javawhere user-controlled input (query.toUpperCase()) was directly concatenated into JPQL query strings (e.g., incompleteAmpAndAmppItem,completePackage, etc.).Direct string concatenation in JPQL queries allows attackers to inject malicious JPQL, potentially enabling unauthorized data access, exfiltration of sensitive hospital/inventory information, or denial of service by crafting resource-intensive queries.
🛡️ Solution: How the fix addresses the vulnerability
Replaced the direct string concatenation with parameterized JPQL queries using named parameters (e.g.,
:q). The case-insensitive matching logic was preserved by using the JPQLupper()function on the columns (e.g.,upper(c.name) like :q) and passing the uppercased input into the parameter map.PR created automatically by Jules for task 18283260539139786552 started by @manupawickramasinghe