🔒 Sentinel: [CRITICAL] Fix JPQL injection in findByFilter methods - #184
Conversation
Implemented a strict allowlist validation for the dynamic 'property' parameter in findByFilter methods across all Bill Controllers to prevent SQL/JPQL injection. Co-authored-by: manupawickramasinghe <73810867+manupawickramasinghe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Fixed a critical JPQL injection vulnerability in multiple Bill Controllers (
findByFiltermethod) where thepropertyparameter was directly concatenated into the JPQL query string.propertystring, potentially allowing them to bypass logic, enumerate data, or execute arbitrary JPQL commands, leading to data exposure or corruption.🛡️ Solution: Implemented a strict allowlist (whitelist) validation. The
propertyparameter is now validated against a list of known safe and expected field names (e.g.,"insId","deptId","patient.person.name") before the query is constructed. If the property is not in the allowlist, the method safely returns false, completely preventing the injection.Affected Controllers:
OpdOrderControllerOpdPreBillControllerBillControllerOpdBatchBillCancellationControllerOpdTabPreBillControllerCollectingCentreBillControllerOpticianRepairBillControllerOpdBillControllerPR created automatically by Jules for task 5915833914436768588 started by @manupawickramasinghe