Adds freeze semantics for pseudo-accounts - #568
Conversation
![xrplf-ai-reviewer[bot]](https://avatars.githubusercontent.com/u/67929741?s=60&v=4){kind=small}
There was a problem hiding this comment.
🟡 Changes recommended
The new Freeze Handling section contains a couple of grammatical errors in table rows and an incorrect rule reference (“Rule 3” vs “Rule 5”) that could mislead implementers.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the XLS-0064 Pseudo-Account specification to define explicit freeze/lock handling rules for protocols that move assets into/out of pseudo-accounts, and refreshes the document’s updated date.
Changes:
- Updates the preamble
updateddate to 2026-06-22. - Adds a new “Freeze Handling” subsection specifying deposit and withdrawal rejection rules (including MPT-specific considerations).
File summaries
| File | Description |
|---|---|
| XLS-0064-pseudo-account/README.md | Adds pseudo-account freeze/lock semantics guidance for deposits/withdrawals and updates the spec metadata date. |
Review details
Suppressed comments (1)
XLS-0064-pseudo-account/README.md:117
- The withdrawal freeze-condition row reads "...the underlying asset of the share if frozen / locked"; this is missing the verb and is grammatically unclear.
| If the asset is a Vault Share, the underlying asset of the share if frozen / locked | `tecLOCKED` |
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Add XLS-64.1 so this PR merges under fixCleanup3_4_0, not a new patch number.
There was a problem hiding this comment.
This is a documentation-only change to the XLS-0064 pseudo-account spec, adding a new 'Freeze Handling' section and a 64.1 patch sub-document. The freeze rules for deposits and withdrawals are internally consistent (issuer bypass, self-withdrawal exemption, deep-freeze vs regular-freeze distinction, MPT lock equivalence to deep-freeze all check out against each other). No code is touched, so there are no functional/security bugs to flag. One minor documentation-structure item is worth a quick sanity check.
There was a problem hiding this comment.
This MR adds a new XLS-64.1 spec document detailing freeze/lock semantics for pseudo-account deposits and withdrawals, and updates the parent XLS-64 README with a matching summary, amendments entry, and changelog. The change is purely documentation/spec text — no executable code is touched. The two documents are internally consistent (deposit/withdrawal condition tables, ordering, issuer/self-withdrawal exemptions, and MPT-lock equivalence all match between the new 64.1 file and the README summary). The main issue found is a metadata inconsistency in the front-matter date.
There was a problem hiding this comment.
This is a documentation-only change adding a new XLS-64.1 patch spec and updating the base XLS-64 README to describe freeze/lock semantics for pseudo-account deposits and withdrawals. The two documents (the new 64.1/README.md and the amended top-level README.md) describe the same rules and are consistent with each other in terms of conditions, ordering, exemptions (issuer destination, self-withdrawal), and MPT lock/deep-freeze equivalence. No code, configuration, or infrastructure is touched, so the categories this review tooling targets (SQL/command injection, resource leaks, race conditions, IAM/K8s/Terraform misconfig, etc.) do not apply. I did not find any factual contradictions, missing exemption cases, or logic errors in the freeze/withdrawal rule tables between the two files.
There was a problem hiding this comment.
This is a documentation-only change adding an XLS-64.1 amendment record and corresponding freeze-semantics section to the XLS-64 pseudo-account spec. I cross-checked the new companion document (64.1/README.md) against the updated main README.md freeze-handling section for consistency in conditions, exemptions (issuer destination, self-withdrawal), deep-freeze vs regular-freeze treatment, and MPT lock equivalence — they align. No code, security-sensitive config, or broken relative links were found; the two new cross-references (./64.1/README.md and ../README.md) both resolve correctly given the files added/modified in this diff. No substantive issues to flag.
High Level Overview of Change
Context of Change
Type of Change