update: make spec changes from BatchV1_1 - #563
Open
mvadari wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the XLS-0056 Batch specification to align with the “BatchV1_1” implementation changes referenced in the linked rippled PR, primarily by tightening BatchSigners rules and clarifying inner-transaction common-field semantics.
Changes:
- Updates XLS metadata and removes the tentative amendment name from the overview.
- Adds/clarifies
BatchSignersrequirements (sorting, signing payload definition, additional failure conditions). - Expands “Transaction Common Fields” to specify
tfInnerBatchTxnfee and validation/failure behavior.
Comment on lines
174
to
+177
| 12. One of the inner transactions fails its preflight checks (i.e. is invalid, irrespective of ledger state) (`temINVALID_INNER_BATCH`). | ||
| 13. Either both or neither of `TicketSequence` and `Sequence` are set (`temSEQ_AND_TICKET`). | ||
| 1. `BatchSigners` | ||
| 1. The length of `BatchSigners` is greater than the number of transactions in `RawTransactions` (`temARRAY_TOO_LARGE`). | ||
| 1. The length of `BatchSigners` is greater than 8 (`temARRAY_TOO_LARGE`). |
Comment on lines
+181
to
+182
| 5. The `BatchSigners` field contains a signature from an account that does not have any inner transactions (`temBAD_SIGNER`). | ||
| 6. The `BatchSigners` field is missing a signature from an account that has inner transactions (`temBAD_SIGNER`). |
Tapanito
reviewed
Jun 17, 2026
Tapanito
approved these changes
Jul 22, 2026
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
|
Checked this against develop, mostly lines up but a few of the failure conditions drifted from the current implementation:
The signing payload section is spot on though, matches serializeBatch exactly. If the intent is to document BatchV1_1 as released then most of this is fine, just flagging where it diverges from 3.x. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Title says it all
Context of Change
XRPLF/rippled#6446
Type of Change