Skip to content

Revert "Did context extension links fhir spec"#102

Open
litlfred wants to merge 1 commit into
mainfrom
revert-80-did-context-extension-links-FHIR-spec
Open

Revert "Did context extension links fhir spec"#102
litlfred wants to merge 1 commit into
mainfrom
revert-80-did-context-extension-links-FHIR-spec

Conversation

@litlfred

Copy link
Copy Markdown
Collaborator

Reverts #80

Copilot AI review requested due to automatic review settings September 22, 2025 23:55

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts changes that were previously made in PR #80, which appears to have added context extension links to FHIR specifications. The revert removes the entire JSON-LD context file that defined vocabulary mappings for trustlist-related concepts.

  • Removes the complete trustlist-context.jsonld file
  • Eliminates vocabulary definitions for keyusage, domain, and participant concepts
  • Reverts context mappings that linked to WHO SMART Trust ValueSet specifications

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions

github-actions Bot commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

✅ Deployment Successful

Branch: revert-80-did-context-extension-links-FHIR-spec
Commit: 029fbb4
Deployed to: https://worldhealthorganization.github.io/smart-base/branches/revert-80-did-context-extension-links-FHIR-spec/

🌐 Open Preview
🔍 View Build Log


Deployment completed successfully! The site is now live at the URL above.

@github-actions

github-actions Bot commented Sep 22, 2025

Copy link
Copy Markdown
Contributor

✅ Deployment Successful

Branch: revert-80-did-context-extension-links-FHIR-spec
Commit: e9f646b
Deployed to: https://worldhealthorganization.github.io/smart-base/branches/revert-80-did-context-extension-links-FHIR-spec/

🌐 Open Preview
🔍 View Build Log


Deployment completed successfully! The site is now live at the URL above.

@litlfred

Copy link
Copy Markdown
Collaborator Author

accidentally merged your PR @kotharikaushal before we could resolve. oops.

@litlfred

Copy link
Copy Markdown
Collaborator Author

@kotharikaushal @ritikarawlani
Here is some documentation/example on how to reference defined valuesets and their codes in a json-ld document (e.g. did.json)
https://github.com/WorldHealthOrganization/smart-base/blob/main/input/scripts/JSON-LD-VALUESET-REQUIREMENTS.md#232-property-level-base
which should let us reference keyusage compactly in the did.json documents.

all jsonld for smart-trust are here https://worldhealthorganization.github.io/smart-trust/dak-api.html

here is example of DEV key usage
https://worldhealthorganization.github.io/smart-trust/ValueSet-KeyUsage-DEV.jsonld

There is jsonld declaration here:
https://worldhealthorganization.github.io/smart-base/DataTypes.jsonld
thats used for fhir:code and fhir:CodeSystem

@litlfred

Copy link
Copy Markdown
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants