Theme Directory: rely on the automated scan result for child theme uploads - #854
Theme Directory: rely on the automated scan result for child theme uploads#854obenland wants to merge 1 commit into
Conversation
…loads Recent Theme Check updates let child themes pass the automated scan on their own, skipping only the requirements their parent provides. The upload handler no longer needs to special-case child themes, so let their scan result apply the same as for any other theme. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
This PR updates the Theme Directory upload flow to treat child theme uploads the same as any other theme by relying on the automated Theme Check scan result, instead of force-passing child themes regardless of scan outcome.
Changes:
- Removed the child-theme-specific override in
check_theme()that always returned a passing result when a parent theme exists. - Ensured the Theme Check scan verdict is applied consistently to both parent and child themes during uploads.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Child themes now pass the automated Theme Check scan on their own — the recent plugin updates skip only the requirements a parent provides (base template functions,
index.php, title-tag support) while still scanning the child's own files.Because of that, the upload handler no longer needs to special-case child themes in
check_theme(). This removes that special-casing so a child theme's scan result is applied the same way as for any other theme.