Skip to content

Tests: Add unit test coverage for WP_Http_Encoding - #14174

Open
huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/http-encoding
Open

huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/http-encoding

Conversation

@huzaifaalmesbah

Copy link
Copy Markdown
Member

Description

Adds a test class for WP_Http_Encoding, which had no tests. The tests cover compress() and its compression level, decompress() for raw deflate, zlib and gzip data and for content it must return unchanged, compatible_gzinflate() with the header checksum, file name and comment gzip header fields and with invalid data, the Accept-Encoding value built by accept_encoding() for each request argument that disables compression, the wp_http_accept_encoding filter arguments and return value, content_encoding(), should_decode() for array, string and non-string headers, and is_available().

Compressed fixtures are built in the test and every expectation is the original literal content.

This is a test-only change; no production code is modified.

Testing Instructions

  1. Run the tests on single site:
    npm run test:php -- --filter 'Tests_HTTP_wpHttpEncoding'
  2. Run them on multisite:
    npm run test:php -- --filter 'Tests_HTTP_wpHttpEncoding' -c tests/phpunit/multisite.xml
  3. Run them in random order:
    npm run test:php -- --filter 'Tests_HTTP_wpHttpEncoding' --order-by=random
  4. Run the whole group to confirm nothing else is affected:
    npm run test:php -- --group http
  5. Run PHPCS on the test file:
    node ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpcs tests/phpunit/tests/http/wpHttpEncoding.php

Trac ticket: https://core.trac.wordpress.org/ticket/65819

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Brainstorming edge-case scenarios and drafting test boilerplate; test architecture, assertions, and local PHPUnit verification were written and validated by me.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant