Repository navigation
Tests: Add unit test coverage for WP_Http_Encoding - #14174
Open
huzaifaalmesbah wants to merge 2 commits into
Open
huzaifaalmesbah wants to merge 2 commits into
huzaifaalmesbah wants to merge 2 commits into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a test class for
WP_Http_Encoding, which had no tests. The tests covercompress()and its compression level,decompress()for raw deflate, zlib and gzip data and for content it must return unchanged,compatible_gzinflate()with the header checksum, file name and comment gzip header fields and with invalid data, theAccept-Encodingvalue built byaccept_encoding()for each request argument that disables compression, thewp_http_accept_encodingfilter arguments and return value,content_encoding(),should_decode()for array, string and non-string headers, andis_available().Compressed fixtures are built in the test and every expectation is the original literal content.
This is a test-only change; no production code is modified.
Testing Instructions
npm run test:php -- --filter 'Tests_HTTP_wpHttpEncoding'npm run test:php -- --filter 'Tests_HTTP_wpHttpEncoding' -c tests/phpunit/multisite.xmlnpm run test:php -- --filter 'Tests_HTTP_wpHttpEncoding' --order-by=randomnpm run test:php -- --group httpnode ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpcs tests/phpunit/tests/http/wpHttpEncoding.phpTrac ticket: https://core.trac.wordpress.org/ticket/65819
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Brainstorming edge-case scenarios and drafting test boilerplate; test architecture, assertions, and local PHPUnit verification were written and validated by me.