Repository navigation
Tests: Add unit test coverage for remove_menu_page() and remove_submenu_page() - #14169
Open
huzaifaalmesbah wants to merge 1 commit into
Open
huzaifaalmesbah wants to merge 1 commit into
huzaifaalmesbah wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds tests for
remove_menu_page()andremove_submenu_page(), which had no coverage. The tests cover the returned menu item, removing only the first matching item while keeping the positions of the others, leaving the submenu (or parent menu) untouched, the empty menu, and the cases that must returnfalsewithout changing anything: unknown, empty, partial and differently cased slugs, a submenu slug passed as a menu slug, a missing parent, and loosely equal values such as the integer123for the slug'123'.The
$menuand$submenuglobals are saved inset_up()and restored intear_down().This is a test-only change; no production code is modified.
Testing Instructions
npm run test:php -- --filter 'Tests_Admin_Includes_Plugin_RemoveMenuPage'npm run test:php -- --filter 'Tests_Admin_Includes_Plugin_RemoveMenuPage' -c tests/phpunit/multisite.xmlnpm run test:php -- --filter 'Tests_Admin_Includes_Plugin_RemoveMenuPage' --order-by=randomnpm run test:php -- --group pluginsnode ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpcs tests/phpunit/tests/admin/includes/plugin/removeMenuPage.phpTrac ticket: https://core.trac.wordpress.org/ticket/65819
Use of AI Tools
AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Brainstorming edge-case scenarios and drafting test boilerplate; test architecture, assertions, and local PHPUnit verification were written and validated by me.