Skip to content

Tests: Add unit test coverage for WP_Fatal_Error_Handler - #14163

Open
huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/65819-fatal-error-handler
Open

huzaifaalmesbah wants to merge 2 commits into
WordPress:trunkfrom
huzaifaalmesbah:tests/65819-fatal-error-handler

Conversation

@huzaifaalmesbah

Copy link
Copy Markdown
Member

Description

Adds a test class for WP_Fatal_Error_Handler, which had no tests. The tests cover should_handle_error() for every PHP error type and the wp_should_handle_php_error filter, detect_error(), the early returns in handle() (no error, unhandled error, sandbox scraping, front end after headers are sent), and each message branch of display_default_error_template() with literal expected output, including the wp_php_error_message and wp_php_error_args filters.

This is a test-only change; no production code is modified.

Testing Instructions

  1. Run the new tests on single site:
    npm run test:php -- --filter 'wpFatalErrorHandler'
  2. Run them on multisite:
    npm run test:php -- --filter 'wpFatalErrorHandler' -c tests/phpunit/multisite.xml
  3. Run them in random order:
    npm run test:php -- --filter 'wpFatalErrorHandler' --order-by=random
  4. Run the whole group to confirm nothing else is affected:
    npm run test:php -- --group error-protection
  5. Run PHPCS on the test file:
    node ./tools/local-env/scripts/docker.js run --rm php ./vendor/bin/phpcs tests/phpunit/tests/error-protection/wpFatalErrorHandler.php

Trac ticket: https://core.trac.wordpress.org/ticket/65819

Use of AI Tools

AI assistance: Yes
Tool(s): Claude Code
Model(s): Claude Opus 5.5
Used for: Brainstorming edge-case scenarios and drafting test boilerplate; test architecture, assertions, and local PHPUnit verification were written and validated by me.

@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props huzaifaalmesbah.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant